doc: update teams in collaborator-guide.md and add links #60065
+91
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
Those links makes the document very hard to read, if we're adding them (and tbh, I'm not sure it's worth it), we would want to add references at the end of the file (i.e. |
|
@aduh95 Good call! |
|
@aduh95 Please have another look, thanks! |
aduh95
reviewed
Oct 7, 2025
| | `lib/inspector.js`, `src/inspector_*` | [@nodejs/v8-inspector][] | | ||
| | `lib/internal/bootstrap/*` | [@nodejs/process][] | | ||
| | `lib/internal/url`, `src/node_url` | [@nodejs/url][] | | ||
| | `lib/net` | [@bnoordhuis][], [@indutny][], [@nodejs/streams][] | |
There was a problem hiding this comment.
I would remove the individual pings (unless you disagree @bnoordhuis @indutny @mscdex @rvagg ?), dealing with teams (that individual can join and leave without updating this doc) seems like a more maintainable approach
Suggested change
| | `lib/net` | [@bnoordhuis][], [@indutny][], [@nodejs/streams][] | | |
| | `lib/net` | [@nodejs/streams][] | |
There was a problem hiding this comment.
Sure, but they are not part of those teams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.